DTM wrapper bug fixes. #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piskvorky , @tmylk , could you review? |
|
I like But it's not a big deal either way. We should just be consistent throughout, whichever terminology we use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
topnfornum_words, wrt #769 .While the same problem as in LdaMallet wrapper (PR #767 ) for it not being backward compatible is there, the PR #755 already made the non-backward compatible changes so I don't think this should be a problem. (@piskvorky , please have a look at this)
At any rate, either only
topnornum_wordsshould be there (not half and half), theprint_topicsfunction will not work otherwise.I've also removed
six.uwith respect to #768 as well.Edit: Made changes to the DTM notebook to reflect this as well.